Add distributed checkpoint reproducibility test#172
Open
taimoorsohail wants to merge 14 commits intomainfrom
Open
Add distributed checkpoint reproducibility test#172taimoorsohail wants to merge 14 commits intomainfrom
taimoorsohail wants to merge 14 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
I think to make this work we would need to uncomment the distributed tests in the CI.yml pipeline |
Collaborator
Author
|
Ah! Didn't know they were commented. Is there a reason for that? No resources or too slow or something? |
Member
|
When we have set up the pipeline we delayed those tests because they need rewriting to fix the GHA way of writing distributed tests. In practice we need to write down strings with the test script and run them with Something like this https://github.com/CliMA/Oceananigans.jl/blob/main/test/test_mpi_tripolar.jl |
simone-silvestri
approved these changes
Apr 21, 2026
Co-authored-by: Simone Silvestri <silvestri.simone0@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/test_distributed_utils.jlT,S,h:rtol=1e-13;u,v,ui,vi:rtol=1e-10), and assert exact clock time/iteration equalityWhy this is needed in addition to serial tests
Implementation notes
Distributed(CPU(), partition=Partition(mpi_ranks, 1))with Codex